koog
koog copied to clipboard
fix: properly pass `BedrockLLMClient` timeout setting to `BedrockRuntimeClient.HttpClient`
Motivation and Context
Working with BedrockLLMClient, I noticed some timeout issues between Koog and bedrock (SocketTimeoutError).
It appears, from my understanding and investigation, the timeout config set in the BedrockLLMClient was not propagated to the HttpClient of the BedrockRuntimeClient.
Breaking Changes
Type of the changes
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] Documentation update
- [ ] Tests improvement
- [ ] Refactoring
Checklist
- [x] The pull request has a description of the proposed change
- [x] I read the Contributing Guidelines before opening the pull request
- [x] The pull request uses
developas the base branch - [x] Tests for the changes have been added
- [ ] All new and existing tests passed
Additional steps for pull requests adding a new feature
- [ ] An issue describing the proposed change exists
- [ ] The pull request includes a link to the issue
- [ ] The change was discussed and approved in the issue
- [ ] Docs have been added / updated
Thank you @TeddyCr I also added the callTimeout configuration and improved unit test a bit
Awesome. Thank you @kpavlov
Does bedrock use only OkHttp?
@devcrocod just pushed the changes.