jewel icon indicating copy to clipboard operation
jewel copied to clipboard

TabStyle is mostly ignored by TabStrip and ultimately, TabImp implementation

Open abarrafo opened this issue 5 months ago • 2 comments

If I pass in a customized TabStyle into TabStrip, it only leverages the scrollBarStyle ignoring other overrides.

I assume this is simply a, "have not gotten to it yet" issue from the team.

Here, tab style never propagates into TabImpl, instead hardcoding style to the available defaults.

@Composable
internal fun TabImpl(
    modifier: Modifier = Modifier,
    isActive: Boolean,
    tabData: TabData,
    interactionSource: MutableInteractionSource = remember { MutableInteractionSource() },
) {
    val tabStyle =
        when (tabData) {
            is TabData.Default -> JewelTheme.defaultTabStyle
            is TabData.Editor -> JewelTheme.editorTabStyle
        }
        
        ...

on a side note, great stuff team . Really like the work your doing.

abarrafo avatar Sep 25 '24 11:09 abarrafo