intellij-platform-gradle-plugin icon indicating copy to clipboard operation
intellij-platform-gradle-plugin copied to clipboard

No support for Gradle `dependencyResolutionManagement`

Open turansky opened this issue 4 years ago • 4 comments

Repositories in dependencyResolutionManagement = failed build

Build Change - idea-plugin folder

turansky avatar Aug 27 '21 02:08 turansky

Ref: https://github.com/gradle/gradle/issues/15754

hsz avatar Aug 27 '21 19:08 hsz

Similar to https://github.com/JetBrains/gradle-grammar-kit-plugin/pull/107 I would just add a check and don't add custom repositories. Adding repositories inside a plugin isn't secure because you can't control it and this repository can contain additional dependencies replacing your dependencies with bad ones.

hfhbd avatar Nov 26 '22 14:11 hfhbd

Looking forward to get this addressed for Jewel, too :)

rock3r avatar Dec 15 '22 14:12 rock3r

Looks like we need to rework dependencies management to something less magical.

hsz avatar Dec 16 '22 16:12 hsz

Implemented in 2.0. It is possible to apply the org.jetbrains.intellij.platform.settings plugin in settings.gradle.kts, which also provides a set for repository helpers to let you add all necessary repositories to the project.

See: https://plugins.jetbrains.com/docs/intellij/tools-intellij-platform-gradle-plugin.html#configuration.dependencyResolutionManagement

hsz avatar Mar 14 '24 15:03 hsz