Util.getBuiltinJbrVersion should allow getting secondJreBuild

[baron1405]

Currently the Util.getBuiltinJbrVersion method returns the jdkBuild version from the dependencies.txt file. Given that some plugin build may wish to use Java 8 instead of Java 11 or vice versa, the getBuiltinJbrVersion method should allow using the BBR specified by the secondJreBuild property. This could be an optional parameter on the method (e.g. useSecondary=false).

One use case is that I would like to be able to specify the JBR used in runIde (i.e. use the primary or secondary JBR).

[zolotov]

I believe secondary jre will always be a temporary thing and I don't really want to introduce a new syntax for this. I think java 8 will be dropped soon and dependency.txt won't have it anymore.

[YannCebron]

this is kinda obsolete now as we require Java 11

[zolotov]

at some point IJ will migrate to Java 14 or 15, so I'd keep the issue

[baron1405]

I closed the issue before reading @zolotov 's comment. I defer to his judgement on the status of this issue.

[YannCebron]

Given that runIde task now has dedicated jbrVersion parameter (https://plugins.jetbrains.com/docs/intellij/tools-gradle-intellij-plugin.html#runide-task-jbrversion), is this still actual?

[baron1405]

This is no longer a factor given only a single JRE is used in IntelliJ at this point.

On Tue, Sep 13, 2022 at 3:04 AM Yann Cébron @.***> wrote:

Given that runIde task now has dedicated jbrVersion parameter ( https://plugins.jetbrains.com/docs/intellij/tools-gradle-intellij-plugin.html#runide-task-jbrversion), is this still actual?

— Reply to this email directly, view it on GitHub https://github.com/JetBrains/gradle-intellij-plugin/issues/413#issuecomment-1245185836, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHRTQ66EA535FFDVTFH3BTV6BGSJANCNFSM4IF6IK3Q . You are receiving this because you modified the open/close state.Message ID: @.***>