intellij-platform-gradle-plugin icon indicating copy to clipboard operation
intellij-platform-gradle-plugin copied to clipboard

Rider plugins cannot be built with useInstaller=true

Open ForNeVeR opened this issue 11 months ago • 1 comments

What happened?

Consider this build.gradle.kts:

dependencies {
    intellijPlatform {
        rider("2024.3.2")
        jetbrainsRuntime()
        instrumentationTools()

        bundledModule("intellij.rider")
        bundledPlugins("com.jetbrains.xaml.previewer")

        testFramework(TestFrameworkType.Bundled)
    }

    implementation(libs.bson4Jackson)

    testImplementation(libs.openTest4J)
}

This will fail, because rider("2024.3.2") leads to implicit useInstaller = true, and Rider (so far) is never supported when building a plugin using installer. See internal issue RIDER-119106 for details on that; there are plans to allow to use the installers but so far it's not possible.

This causes confusion among users (especially since you migrate from 243 EAP to 243 and build gets broken — it's not easy to figure out that it's the implicit property that gets switched between these).

I suggest us to automatically disable useInstaller for Rider, unless it's been explicitly passed as useInstaller = true (while I never seen cases when it's used and works, theoretically it's possible for some very light usages, e.g. when a plugin only depends a conditional XML file or something like that).

Gradle IntelliJ Plugin version

2.2.0

Gradle version

8.12

Operating System

None

Link to build, i.e. failing GitHub Action job

No response

ForNeVeR avatar Dec 22 '24 20:12 ForNeVeR

I hope it's okay.

But just for the ones who are not gradle experts like me. If you get this warning you should for example change

rider("2024.3.2") to rider("2024.3.2", useInstaller=false)

jeppevammenkristensen avatar Mar 18 '25 22:03 jeppevammenkristensen