intellij-platform-gradle-plugin
intellij-platform-gradle-plugin copied to clipboard
Fixed generation of duplicate files in ".intellijPlatform/localPlatformArtifacts" with different version numbers.
Pull Request Details
Fixed generation of duplicate files in ".intellijPlatform/localPlatformArtifacts" with different version numbers. As usual, it also includes #1792 because master is broken. The tests will fail on OSX, see why in #1792
Description
The duplicates were created because here it was val version = requireNotNull(plugin.pluginVersion)
https://github.com/JetBrains/intellij-platform-gradle-plugin/blob/main/src/main/kotlin/org/jetbrains/intellij/platform/gradle/extensions/IntelliJPlatformDependenciesHelper.kt#L814
So I did the same in createIntelliJPlatformBundledPlugin.
This also results in a more consistent dependency graph, e.g. see before & after:
Related Issue
No.
Motivation and Context
It was confusing.
How Has This Been Tested
Running tests, manually.
Types of changes
- [ ] Docs change / refactoring / dependency upgrade
- [ x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
Checklist
- [x ] I have read the CONTRIBUTING document.
- [ x] My code follows the code style of this project.
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [ x] I have included my change in the CHANGELOG.
- [ ] I have added tests to cover my changes.
- [x ] All new and existing tests passed.
Tests on OSX failed because of #1792 and on Windows that is a random test failure, which seems to happen in this project.