An attempt to fix bugs & broken tests.

[AlexanderBartash]

Pull Request Details

An attempt to fix broken tests in master.

Description

:point_up:

Related Issue

No.

Motivation and Context

They are broken?

How Has This Been Tested

By running tests.

Types of changes

• [ ] Docs change / refactoring / dependency upgrade
• [ x] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• [x ] I have read the CONTRIBUTING document.
• x[ ] My code follows the code style of this project.
• [ ] My change requires a change to the documentation.
• [ ] I have updated the documentation accordingly.
• [ ] I have included my change in the CHANGELOG.
• [ ] I have added tests to cover my changes.
• [ ] All new and existing tests passed.

[AlexanderBartash]

So tests on mac randomly fail with:

> Task :buildSearchableOptions FAILED
CompileCommand: exclude com/intellij/openapi/vfs/impl/FilePartNodeRoot.trieDescend bool exclude = true
2024-10-12 21:57:43,076 [    639]   WARN - #c.i.o.e.c.i.EditorColorsManagerImpl - resource not found: colorSchemes/LogcatColorSchemeDefault.xml
2024-10-12 21:57:43,077 [    640]   WARN - #c.i.o.e.c.i.EditorColorsManagerImpl - resource not found: colorSchemes/LogcatColorSchemeDarcula.xml
Assertion failed: (count <= len && "snprintf() output has been truncated"), function LOAD_ERROR, file dispatch.c, line 74.
#
# A fatal error has been detected by the Java Runtime Environment:
#
#  SIGABRT (0x6) at pc=0x000000019785d5d0, pid=5661, tid=25347
#
# JRE version: OpenJDK Runtime Environment JBR-17.0.6+1-653.34-jcef (17.0.6+1) (build 17.0.6+1-b653.34)
# Java VM: OpenJDK 64-Bit Server VM JBR-17.0.6+1-653.34-jcef (17.0.6+1-b653.34, mixed mode, tiered, compressed oops, compressed class ptrs, g1 gc, bsd-aarch64)
# Problematic frame:
# C  [libsystem_kernel.dylib+0x95d0]  __pthread_kill+0x8
#
# No core dump will be written. Core dumps have been disabled. To enable core dumping, try "ulimit -c unlimited" before starting Java again
#
# An error report file with more information is saved as:
# /Users/runner/work/intellij-platform-gradle-plugin/intellij-platform-gradle-plugin/build/testGradleHome/caches/8.10.2/transforms/b559d1bba72cbf9412e69779fe6c143e/transformed/ideaIC-2022.3.3-aarch64/hs_err_pid5661.log
#
# If you would like to submit a bug report, please visit:
#   https://youtrack.jetbrains.com/issues/JBR
# The crash happened outside the Java Virtual Machine in native code.
# See problematic frame for where to report the bug.

I give up.

[hsz]

Rejecting this PR, as agreed. I'll consume few correct changes from this PR directly into main branch, though:

• test searchable options in 242+ – bumping the IntelliJ Platform to the more recent version fixes the Java Compiler. Assertion update is also a correct move.
• good catch with it.size == 2 check when parsing version of the custom JBR

Thanks!