intellij-platform-gradle-plugin icon indicating copy to clipboard operation
intellij-platform-gradle-plugin copied to clipboard

v2.1.0 breaks compilation for Rider plugins — an explicit reference to intellij.rider is required

Open ForNeVeR opened this issue 1 year ago • 3 comments

What happened?

After updating to v2.1.0 in my Rider plugin (see this commit), I see a new compilation failure. It looks like the plugin no longer automatically adds bundled product modules, even though I expect them to be auto-included. At least in the case of Rider, this is a must — there's no point in building a Rider plugin without referencing the intellij.rider product module.

Note that it is marked as a product module v2 in product-info.json of the corresponding Rider version:

    {
      "name": "intellij.rider",
      "kind": "productModuleV2",
      "classPath": [
        "lib/modules/intellij.rider.jar"
      ]
    }

Relevant log output or stack trace

> Task :compileKotlin
e: file:///home/runner/work/AvaloniaRider/AvaloniaRider/src/rider/main/kotlin/me/fornever/avaloniarider/idea/editor/AvaloniaPreviewEditorBase.kt:28:28 Unresolved reference: build

Steps to reproduce

  1. Check out this commit of AvaloniaRider.
  2. ./gradlew :assemble
  3. Observe the compilation error.

Workaround: add bundledModule("intellij.rider")

Gradle IntelliJ Plugin version

2.1.0

Gradle version

8.10.2

Operating System

None

Link to build, i.e. failing GitHub Action job

https://github.com/ForNeVeR/AvaloniaRider/actions/runs/11035451027/job/30651456122

ForNeVeR avatar Sep 25 '24 21:09 ForNeVeR

After upgrading to the latest version, we experience this problem as well. Several parts of the SDK are no longer available to us.

Most importantly:

  • dotnet debugging
  • wormhole
  • systemenvironmentprovider

I suspect that this is due to the reason @ForNeVeR mentioned in his report, the entirety of the Rider framework isn't in the SDK as far as I can tell.

yodax avatar Sep 30 '24 07:09 yodax

Now I see markup in my post has been broken (by myself probably). You might've missed the workaround: add bundledModule("intellij.rider"). For me it started to work after that.

ForNeVeR avatar Sep 30 '24 10:09 ForNeVeR

Can confirm; the workaround works 👍

yodax avatar Sep 30 '24 12:09 yodax

Thanks for reporting. This module will be now available for Rider automatically.

hsz avatar Dec 03 '24 21:12 hsz