intellij-platform-gradle-plugin icon indicating copy to clipboard operation
intellij-platform-gradle-plugin copied to clipboard

fix: Mark coroutinesJavaAgentFile as a classpath entry

Open blorente opened this issue 1 year ago • 0 comments

Pull Request Details

Description

Change IntelliJPlatformArgumentProvider.coroutinesJavaAgentFile to be a @Classpath instead of @PathSensitive(RELATIVE) to fix normalization.

Related Issue

#1554

Motivation and Context

Timestamps are not ignored when using @PathSensitive(RELATIVE), which leads to the coroutines-javaagent.jar files over-invalidating and causing cache misses. See this comment.

How Has This Been Tested

I ran the IdeaVIM plugin against a local instance of Develocity with the local cache enabled.

  • Before the change, we reproduced this issue: The build comparator showed that the coroutines-javaagent.jar was different, thus invalidating the cache key. The only difference between the two jars in that build were the timestamps.
  • After the change, the jar was correctly cached.

Types of changes

  • [ ] Docs change / refactoring / dependency upgrade
  • [X] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • [X] I have read the CONTRIBUTING document.
  • [X] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [X] I have included my change in the CHANGELOG.
  • [ ] I have added tests to cover my changes.
  • [X] All new and existing tests passed.

blorente avatar Aug 21 '24 09:08 blorente