intellij-platform-gradle-plugin icon indicating copy to clipboard operation
intellij-platform-gradle-plugin copied to clipboard

2.0 - Use the built-in Gradle version checker

Open hfhbd opened this issue 1 year ago • 0 comments

Pull Request Details

Gradle added the GradlePluginApiVersion.GRADLE_PLUGIN_API_VERSION_ATTRIBUTE to use the build-in variant mechanism to select a compatible Gradle plugin, or fails the build. The downside of the build-in option is the massive wall of text (the variant error output) when you consume your Gradle plugin with a lower Gradle version, eg 8.0.

But, starting with Gradle 8.7, the variant error output is more human readable: https://github.com/gradle/gradle/issues/24609

This PR removes the custom check but with down-side of suboptimal experience using Gradle < 8.7.

Question: Do you want it?

Description

Related Issue

Motivation and Context

How Has This Been Tested

Types of changes

  • [ ] Docs change / refactoring / dependency upgrade
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • [ ] I have read the CONTRIBUTING document.
  • [ ] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have included my change in the CHANGELOG.
  • [ ] I have added tests to cover my changes.
  • [ ] All new and existing tests passed.

hfhbd avatar Mar 02 '24 11:03 hfhbd