JetBrains
Polish characters work regardless of locale
On Windows, Polish keyboard layout (and a few others) remaps Right Alt to AltGr (Alt Graph) key. For such keyboard layouts pressing right Alt sends two key press events: Left Ctrl and Right Alt. This is due to a fact that Ctrl+Alt is also used in Windows as a AltGr key mapping.
On such keyboards, to access national characters users have following options: Ctrl(any) + Alt (any) + letter or Right Alt + Letter with vast majority of users using the latter.
Unfortunately, Android Studio uses plenty of shortcuts in form of Ctrl+Alt+letter. These shortcuts take precedence over typing the accented character. To make things work, Android Studio uses current locale to detect if Polish keyboard layout (or another with similar property) is used.
This is not ideal - locale is not equal to keyboard layout. Users who have English locale, but use Polish keyboard are not able to enter accented characters that have keybinding mapping defined for them. There are two workarounds, none of them satisfactory: add a custom property to idea.properties file (hard to discover) or remove keybindings for each accented letter.
Fix: Java sets keyChar property on KeyEvent whenever a key combination would result in typing a character. If the property is set and it would be a result of pressing Left Ctrl+Right Alt then ignore and shortcut mappings to give precedence to typing a character.
Other changes:
- Removed the workaround as it is no longer needed.
- Cleaned up the code that tracks left ctrl/right alt. It didn't work correctly when both left and right Ctrl keys/Alt keys were pressed.
- The workaround did not work for uppercase characters due to missing check for the Shift key.
See Android Studio issue for more context: https://issuetracker.google.com/68750785
Change-Id: I840ffcc9e653ca6e8942242c017056dc1252e1e0 Test: added IdeKeyEventDispatcherTest.testPolish()
