intellij-community icon indicating copy to clipboard operation
intellij-community copied to clipboard

Fixes KTIJ-18835: Adding curly braces with labeled object in string template

Open abhinav12k opened this issue 1 year ago • 7 comments

Fixes issue - KTIJ-18835

abhinav12k avatar Apr 07 '23 15:04 abhinav12k

There is already a PR for this issue: https://github.com/JetBrains/intellij-community/pull/2374

abelkov avatar Apr 10 '23 05:04 abelkov

Could you please add tests ?

vladimirdolzhenko avatar Apr 19 '23 10:04 vladimirdolzhenko

Hi @vladimirdolzhenko, Can you please any reference / example for test cases. I haven’t wrote any test case for intellij plugin.

abhinav12k avatar Apr 21 '23 08:04 abhinav12k

you can use something like test data used by https://github.com/JetBrains/intellij-community/blob/master/plugins/kotlin/completion/tests-k1/test/org/jetbrains/kotlin/idea/completion/test/handlers/BasicCompletionHandlerTestGenerated.java -> https://github.com/JetBrains/intellij-community/tree/master/plugins/kotlin/completion/testData/handlers/basic

to regererate test classes you can use org.jetbrains.kotlin.idea.testGenerator.all.GenerateAllTestsKt or Generate Kotlin Tests (K1 + K2) run configuration in IntelliJ

vladimirdolzhenko avatar Apr 21 '23 11:04 vladimirdolzhenko

@vladimirdolzhenko Added test cases. Please check

abhinav12k avatar Apr 25 '23 05:04 abhinav12k

@abhinav12k could you pls rebase on the latest master branch? as the actual commit has 5000+ changed files.

vladimirdolzhenko avatar Jun 06 '23 10:06 vladimirdolzhenko

@vladimirdolzhenko Rebased. Can you please check

abhinav12k avatar Jun 16 '23 18:06 abhinav12k