intellij-community icon indicating copy to clipboard operation
intellij-community copied to clipboard

Published 20 hours ago • verified publisher icon JetBrains

[maven] IDEA-296303 respect preview property and parameter

Open beatngu13 opened this issue 1 year ago • 3 comments

Fixes IDEA-296303.

beatngu13 avatar Mar 04 '23 09:03 beatngu13

Hi @zulkar,

just synced my fork because the diff was a mess after that force push on master.

Is there anything else I can do to get this PR merged?

beatngu13 avatar Jun 02 '23 13:06 beatngu13

JDK 21 is just around the corner, including several JEPs as preview features (e.g. String templates). IntelliJ/Maven users would benefit from this PR, since the preview property and parameter are respected.

Is there a chance to move forward with this PR?

beatngu13 avatar Sep 12 '23 17:09 beatngu13

Hey @zulkar,

almost a year has passed, is there a chance to move forward with this PR?

beatngu13 avatar Feb 06 '24 21:02 beatngu13

@beatngu13 thank you for the contribution. And separately, thank you for providing updated tests! Will run the pull request through our CI soon.

nskvortsov avatar Apr 10 '24 14:04 nskvortsov

Merged to master. I apologize for this pull request being stuck for a crazy long time. Thank you for your patience and a solid contribution!

nskvortsov avatar Apr 10 '24 19:04 nskvortsov