intellij-community icon indicating copy to clipboard operation
intellij-community copied to clipboard

Published 20 hours ago • verified publisher icon JetBrains

[IDEA-290250] Improve the order of the editor popup menu entries

Open Fabrice-TIERCELIN opened this issue 4 years ago • 7 comments

Hi,

Among other entries, we have:

Find Usages Refactor

Folding Analyze

Go to Generate...

Find Usages and Go to are both navigation features. Refactor and Generate... are both automatic code writing features. They should be gathered. I suggest to switch Refactor and Go to.

@yole, I have successfully tested.

Fabrice-TIERCELIN avatar Jun 23 '21 17:06 Fabrice-TIERCELIN

@ybedrov, perhaps it should be reassigned. The PR hasn't changed for 10 months.

Fabrice-TIERCELIN avatar Apr 18 '22 17:04 Fabrice-TIERCELIN

The change looks logical but there are 2 considerations:

  1. muscle memory
  2. probably Go To actions are used by shortcuts more than refactorings, so the change would result in more "scrolling" for them. What do you think, does it really worth it? Thanks

akozlova avatar Apr 27 '22 09:04 akozlova

I can invert the order if you want:

Generate... Refactor

Folding Analyze

Find Usages Go to

Muscle memory is important, but it's better to consider the future than the past.

Fabrice-TIERCELIN avatar Apr 28 '22 04:04 Fabrice-TIERCELIN

Doesn't solve the second issue, that goto is most probably invoked with the mouse or shortcut.

akozlova avatar Apr 28 '22 07:04 akozlova

So let's keep Go to... at the same place and move the others. There are a number of possibilities!

Fabrice-TIERCELIN avatar Apr 28 '22 18:04 Fabrice-TIERCELIN

@akozlova, to move the debate forward, I suggest to move only one entry, let's say Go to:

Find Usages Go to Refactor

Folding Analyze

Generate...

Fabrice-TIERCELIN avatar Jul 31 '22 14:07 Fabrice-TIERCELIN

@yole I think, I am fine with the suggested change, you?

akozlova avatar Aug 01 '22 12:08 akozlova

Thanks for your contribution! We implemented part of these changes internally; I hope the result works well for you.

yole avatar Dec 29 '22 13:12 yole

I had the opportunity to test it successfully on IntelliJ 2021.1.3

I can't test on a more recent installation because we can't hack the files of the installation on the further versions.

Fabrice-TIERCELIN avatar Jan 07 '23 18:01 Fabrice-TIERCELIN

I have successfully verified this feature with this configuration: IntelliJ IDEA 2023.1 EAP (Community Edition) Build #IC-231.4840.387, built on January 19, 2023 Runtime version: 17.0.5+8-b759.1 amd64 VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o. Windows 10 10.0 GC: G1 Young Generation, G1 Old Generation Memory: 1010M Cores: 4 Non-Bundled Plugins: com.dubreuia (2.3.0)

Kotlin: 231-1.7.21-release-272-IJ4840.387

Fabrice-TIERCELIN avatar Jan 24 '23 08:01 Fabrice-TIERCELIN