intellij-community icon indicating copy to clipboard operation
intellij-community copied to clipboard

Update kotlin style format to kotlin style guide

Open darkrecruit opened this issue 5 years ago • 8 comments

This change is generated from Kotlin's code style setting menu. Click on "Set from..." and then choosing "Kotlin style guide".

darkrecruit avatar Nov 15 '19 17:11 darkrecruit

Let's remake the commit by opening the intellij-community project in IDEA instead of copy-pasting from the Android Studio project in a text editor.

dahlstrom-g avatar Nov 15 '19 23:11 dahlstrom-g

done

darkrecruit avatar Nov 18 '19 18:11 darkrecruit

Let's remake the commit by opening the intellij-community project in IDEA instead of copy-pasting from the Android Studio project in a text editor.

It looks like this isn't done. (?)

dahlstrom-g avatar Nov 18 '19 19:11 dahlstrom-g

It was done by opening intellij-community project in IDEA.

On Mon, Nov 18, 2019 at 11:00 AM Dana Dahlstrom [email protected] wrote:

Let's remake the commit by opening the intellij-community project in IDEA instead of copy-pasting from the Android Studio project in a text editor.

It looks like this isn't done. (?)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/JetBrains/intellij-community/pull/1248?email_source=notifications&email_token=AALJ6LTDYETCRCUMUMRTN2DQULQ5HA5CNFSM4JN6KHQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEELRCFQ#issuecomment-555159830, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALJ6LWYQVY63BIV5K3RVPDQULQ5HANCNFSM4JN6KHQQ .

darkrecruit avatar Nov 18 '19 22:11 darkrecruit

It was done by opening intellij-community project in IDEA.

It doesn't look like it. I tried this with IDEA 2019.2.4 and got different results—I'm all but certain commit 324dfc5 is contaminated with settings from the Android Studio project.

dahlstrom-g avatar Nov 19 '19 20:11 dahlstrom-g

This should be it. I'm using IDEA 2019.2.3

On Tue, Nov 19, 2019 at 12:00 PM Dana Dahlstrom [email protected] wrote:

It was done by opening intellij-community project in IDEA.

It doesn't look like it. I tried this with IDEA 2019.2.4 and got different results—I'm all but certain commit 324dfc5 https://github.com/JetBrains/intellij-community/commit/324dfc54ba0106c265ddb5622d461f96cd31c971 is contaminated with settings from the Android Studio project.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/JetBrains/intellij-community/pull/1248?email_source=notifications&email_token=AALJ6LWRY2ZVGIFD2ZWSBE3QURAWDA5CNFSM4JN6KHQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEPRIQI#issuecomment-555684929, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALJ6LS262BPSTRSLSPSOL3QURAWDANCNFSM4JN6KHQQ .

darkrecruit avatar Nov 19 '19 21:11 darkrecruit

Yes, commit 03922a7 matches what I saw with both 2019.2.3 and 2019.2.4. Thanks!

dahlstrom-g avatar Nov 19 '19 23:11 dahlstrom-g

Thanks for double checking!

On Tue, Nov 19, 2019 at 3:00 PM Dana Dahlstrom [email protected] wrote:

Yes, commit 03922a7 https://github.com/JetBrains/intellij-community/commit/03922a7340cee92352f0abae84019d57d028c766 matches what I saw with both 2019.2.3 and 2019.2.4. Thanks!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/JetBrains/intellij-community/pull/1248?email_source=notifications&email_token=AALJ6LRE4NOXMG2QPU3B6VTQURVY3A5CNFSM4JN6KHQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEQCRZA#issuecomment-555755748, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALJ6LQLK3BHRITE7HWJOPTQURVY3ANCNFSM4JN6KHQQ .

darkrecruit avatar Nov 19 '19 23:11 darkrecruit