intellij-community
intellij-community copied to clipboard
JetBrains
Focus lost upon opening certain important dialogs.
this fixes absence of focus in edit field upon opening "Find in Path" dialog and "Evaluate expression" dialog.
Symptoms: sometimes (there's racing somewhere) focus and caret remain in code editor window after launch of specified dialogs. Arch(Manjaro) Linux, Cinnamon or KDE. Same racing is very rare on non-compositing mode openbox WM.
Cause: under some conditions native awt peer refuses to focus window which has not been yet created and workarounds found around in awt do not work. JDK versions 11 and 8 (oracle/JB/openjdk) show same behavior.
Fix: making sure focus is requested AFTER window has been opened, not relying on awt magic to track and properly route focus requests scheduled in advance. Thankfully, JB code does not need much work.
JB, PLEASE fix same stuff in CLion PLEASE! Impossible to work.
Have you submitted a contributor license agreement? If not, please follow the steps described at http://www.jetbrains.com/agreements/cla/ to sign it.
Done
On Sun, Jun 30, 2019, 4:49 PM Kirill Likhodedov [email protected] wrote:
Have you submitted a contributor license agreement? If not, please follow the steps described at http://www.jetbrains.com/agreements/cla/ to sign it.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/JetBrains/intellij-community/pull/1164?email_source=notifications&email_token=AAHIOB7XENFI6B6QDSTJ7E3P5C2YBA5CNFSM4H4MO6KKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY4MR7Y#issuecomment-507037951, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHIOB3KSDKTU2SKJR5UFJDP5C2YBANCNFSM4H4MO6KA .
And signed.
On Sun, Jun 30, 2019 at 4:52 PM Alex Bitney [email protected] wrote:
Done
On Sun, Jun 30, 2019, 4:49 PM Kirill Likhodedov [email protected] wrote:
Have you submitted a contributor license agreement? If not, please follow the steps described at http://www.jetbrains.com/agreements/cla/ to sign it.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/JetBrains/intellij-community/pull/1164?email_source=notifications&email_token=AAHIOB7XENFI6B6QDSTJ7E3P5C2YBA5CNFSM4H4MO6KKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY4MR7Y#issuecomment-507037951, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHIOB3KSDKTU2SKJR5UFJDP5C2YBANCNFSM4H4MO6KA .