compose-multiplatform icon indicating copy to clipboard operation
compose-multiplatform copied to clipboard

Cleanup old MouseScroll API in AOSP

Open jimgoog opened this issue 3 years ago • 2 comments

The compose-jb version of TestComposeWindow is already using the new API. The only reason we are using the old MouseScroll API in AOSP is because we want to wait until 1.2-alpha to merge aosp/1837304 which provides the replacement API, but that replacement API is already in the compose-jb repo, which means that Compose MPP 1.0 does not use the old MouseScroll API and this API can thus be removed without being a breaking change and without a major version number bump.

We should remove the deprecation the AOSP copy of DesktopScrollableTest.kt and tests should either be deleted or updated to perform the same test using the new API.

Place where suppression was added:

  • compose/foundation/foundation/src/desktopTest/kotlin/androidx/compose/foundation/gestures/DesktopScrollableTest.kt
  • compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/TestComposeWindow.desktop.kt
  • compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/input/mouse/MouseHoverFilterTest.kt
  • compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/input/mouse/MouseScrollFilterTest.kt
  • compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/window/window/WindowInputEventTest.kt
  • compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/input/mouse/MouseScrollFilter.skiko.kt

jimgoog avatar Dec 01 '21 02:12 jimgoog