MPS icon indicating copy to clipboard operation
MPS copied to clipboard

MpsLoadTask: simplify and fix the MPS home check

Open sergej-koscejev opened this issue 1 year ago • 1 comments

The original code was checking getPath(), which is the full path of a file, against "build.txt", which is just the name.

Also, it isn't necessary to iterate through all the files when we can simply check for existence of a file.

sergej-koscejev avatar Oct 26 '23 11:10 sergej-koscejev

This went unnoticed for quite some time probably because it only works if assertions are enabled, and they usually aren't.

sergej-koscejev avatar Oct 26 '23 11:10 sergej-koscejev

An issue in the MPS YouTrack: https://youtrack.jetbrains.com/issue/MPS-37669/pull-request-Modify-MpsLoadTask-to-correct-MPS-home-verification-logic

ashatalin avatar Aug 09 '24 07:08 ashatalin

Done by @mvlassiev

sergej-koscejev avatar Aug 16 '24 12:08 sergej-koscejev