MPS-extensions icon indicating copy to clipboard operation
MPS-extensions copied to clipboard

Icons not shown in MPS 2020.3

Open eugenschindler opened this issue 3 years ago • 9 comments

In MPS 2020.3, the icons are displayed like this: image

eugenschindler avatar Apr 11 '21 15:04 eugenschindler

I think I have also seen this at some point, but I just tried it out with the latest MPS (2020.3.3) and now I see the icons again: image

Do you still have the issue?

klemensschindler avatar May 11 '21 20:05 klemensschindler

Just tried it under MPS 2020.3.3 (Ubuntu): Screenshot from 2021-05-11 22-46-51

eugenschindler avatar May 11 '21 20:05 eugenschindler

I am currently using Windows and have installed MPS via the JetBrains toolbox, so maybe this only happens on some platforms or MPS releases.

Could you try to open the MPS-extensions project and open one of the toolbar actions and check if you see the same here? image

If you see nothing there, can you also try to select another icon with the ...?

Some guesses on what could be going on:

  1. The icons are PNG. Could there be an issue related to PNG rendering under the particular Java version or Ubuntu version?
  2. Could it be a path issue (Windows vs Linux)?
  3. Could the issue be specific to an MPS release type? (jetbrains toolbox, windows, linux, universal)

klemensschindler avatar May 11 '21 20:05 klemensschindler

Thanks for the helpful checklist. I will collect more info.

Starting with trying it myself under Windows (MPS via JetBrains toolbox, including MPS Extensions, mbeddr and IETS3 - so not standalone langvis from plugin repo): image

eugenschindler avatar May 12 '21 08:05 eugenschindler

OK, that is interesting. I have opened MPS-extensions source in Linux and then it just seems to work: Screenshot from 2021-05-12 14-28-55

Next step is to check if this built plugin will also act that way...

eugenschindler avatar May 12 '21 12:05 eugenschindler

Now I have just taken the built plugin from the artifacts folder of the MPS-extensions repository that I just made a screenshot of in the last comment and the result is this: Screenshot from 2021-05-12 15-00-58 Conclusion: something happens with the packaging. @klemensschindler can you verify if you get the same behavior as me with a pre-installed version from the plugin repo or by copying a built version of langvis and try that (like I did in this comment)?

eugenschindler avatar May 12 '21 13:05 eugenschindler

Check in the build solution whether you copy resources properly, there were changes in this area in the last few versions of MPS: image

sergej-koscejev avatar May 14 '21 07:05 sergej-koscejev

These resources are in order in the build script. Thanks to an MPS-office-hours session from @sergej-koscejev, there is the tip from Sergej to look to check the global java option to copy the resources. @MariaLebedeva has also given a link to a related issue of missing icons, but unfortunately I cannot find the link right now.

eugenschindler avatar Jun 22 '21 18:06 eugenschindler

It appears that MPS 2021.1.1 copies the files correctly now, but they are still not shown. So: the icons folder is there, but the icons are still not shown. Now I'm really confused! @sergej-koscejev any idea? If not, I will come annoy with at again at the next MPS Office Hours :)

eugenschindler avatar Jul 09 '21 16:07 eugenschindler