Line spacing widened in v1.0.3

[vianpl]

I observed the line spacing widened between v1.0.2 and v1.0.3. Personally I like the old spacing better (it's tighter), and although most terminals allow widening the line spacing, they don't generally allow the opposite, which made me go back to v1.0.2.

I suggest going back to the previous spacing for next version.

Thanks!

[philippnurullin]

@vianpl Hi, can you send me the screenshots of how v1.0.2 & v1.0.3 looks in your terminal?

[vianpl]

Here's a screenshot, left uses v1.0.2, right v1.0.3, I'm running vim in konsole (borderless) on a gnome/wayland system. The only thing that changed prior opening the second window is the fact that I replaced v1.0.2 with v1.0.3 in my '.fonts' directory.

[andrebrait]

I aligned his screenshots and kept only the green channel of the image on the right. It seems the line height increased a bit, indeed.

[philippnurullin]

To be precise, the line height increased by 2 pixels. Thats actually a lot, looks like some rounding up is involved, in the process of rendering font in vim. We can't change that.

The line height was increased a bit (from 1225 to 1240, about 1,2%), it was made to properly support the Box Drawing. I don't have a solution to this issue right now. Need to think more. Sorry.

[Longhanks]

The newest CLion and IntelliJ 2020.1 EAPs now ship v1.0.3. I agree with this issue, I prefer the old line height. I had to manually replace the ttf files inside the JetBrains runtime to make the IDEs pick up the old versions of JetBrains Mono.

I'd much prefer if the next release could go back to the height of v1.0.2.

[philippnurullin]

@Longhanks You can change the Line spacing in settings. Go to Editor → Font.

[cglogic]

I am the other one who reverted 1.0.3 update to v1.0.2 because of this. I use this font in several terminal emulators. However, the font is awesome. Thanks for your work!

[Longhanks]

@philippnurullin This only changes the spacing in between the lines, not the line of the heights themselves. The line height changed between v1.0.2 and v1.0.3.

See this comparison screenshot, left is v1.0.2, right is v1.0.3:

[philippnurullin]

@Longhanks Correct me if i'm mistaking. You ok with the height of the line but you don't like that that letter are taller. Is thats the case?

[Longhanks]

@philippnurullin Yes. I prefer the look of v1.0.2.

[vikky49]

But there are also people like me who like the new spacing in 1.0.3 :-)

[philippnurullin]

@Longhanks Thees are two separate problems.

1. Increased the line heights. This was not intended. I wrote about this issue higher.

2. Increased x-height of letters. In your case you can decrease the size to 12px. This will give you almost the exact result as the 13px in 1.0.2. It may also need a little line more line height. Which you can increase in your IDE settings. We don't see it as a problem because letter became bigger & easy to read. This change is intentional.

@vikky49 Glad to hear it. )

[Longhanks]

That’s very unfortunate to hear. I’ll have to keep a fork of the repo at v1.0.2 then.

[vianpl]

FYI Tested v1.0.4, the issue persists (unsurprisingly, as no relevant changes mentioned in the change log).

[doodhout]

Line spacing (or line height or whatever it is that causes less lines to be visible on a certain screen) is currenty like so for v1.0.3:

Liberation Sans Mono (my current font) at font size=12 and lineheight=1.0 can fit the same amount of lines on the screen as Jetbrains Mono at font size=11 and lineheight=1.0 but alas the Jetbrains Mono font is rendered significantly smaller and more difficult to read at that size, so disadvantage to JBM. Another possibility is to set the lineheight to 0.85 while keeping font size at 12, but the option to use a lineheight lower than 1.0 is not present in every application in which I use the font, thus making this at most a partial fix for the problem.

SUGGESTION: Please release next to the regular font and the non-ligature font also a version with smaller lineheight so people can use it anywhere at the default lineheight setting and still retain their dense lines.

MOTIVATION: Currently I use the quite outdated Liberation Sans Mono because it's the only font that gives me both large characters at a small enough lineheight to my liking. I'm guessing there are other people that feel the same way, hence the need they feel to open issues like these.