Jonathan MASSUCHETTI

Results 144 comments of Jonathan MASSUCHETTI

@connor4312 is there any way to disable such optimization ? I tried several node flags without success. This gets really annoying during some debug sessions. EDIT : even if it...

Still no update, it would be so bad to let this die !

> Looks like the tests fail ? See for example https://github.com/antlr/antlr4/actions/runs/8723991967/job/23933679496?pr=4597 I fail to run the tests locally using maven. I haven't touch to java in a while so I'm...

> Fixes the failing tests, but not sure it satisfies the requirement to test against the built package (vs the source project) I was hesitant to test against the build...

@ericvergnaud just pinging in case you didn't see my edit above

> Ah I see what you mean. But how can we be sure that your test samples are using the `dist` folder ? The test uses the package.json. The package.json...

@ericvergnaud after migrating the project using this lib to pnpm, I noticed the types stopped to work altogether. After looking around I noticed that the imports inside the definition files...

@ericvergnaud The need for the extension comes from the `node16` TypeScript target. TypeScript uses the `d.ts` files, so it's unrelated to the packaged source files.

@ericvergnaud When I mention `node16` I'm talking about the TS compiler option "target". Not the node runtime version. `pnpm` is the most strict package manager. It enforces standards and prevent...

I understand the need for small steps. `pnpm` falls into the support for node >= 16, since it's officially distributed by Node.js via `corepack`. I understand the commit touches a...