pypandoc icon indicating copy to clipboard operation
pypandoc copied to clipboard

Added parameter to control if files are sorted before being passed to pandoc

Open colinbull opened this issue 1 year ago • 5 comments

Small PR to allow the sorting behaviour to be controlled before the file sets are passed to the pandoc process. Previously files were always sorted. However, this can lead to the wrong ordering in the generated documents if the sorted order file names don't represent the required order in the generated documents.

colinbull avatar Oct 12 '24 17:10 colinbull

Hi @colinbull thanks for the pr.

I added a comment, and then there's some CI failing

JessicaTegner avatar Oct 14 '24 16:10 JessicaTegner

Humm the build failing looks like python is failing to install correctly on the windows builds:

No Python at '"C:\hostedtoolcache\windows\Python\3.12.6\x64\python.exe'

Don't have time at the minute but will look at this, although it is likely not related to this PR.

colinbull avatar Oct 14 '24 16:10 colinbull

yes indeed doesn't seem related. I'll try rerunning the failing jobs later, to see if it's a GH issue, cause it seems very strange.

JessicaTegner avatar Oct 14 '24 16:10 JessicaTegner

No worries, I'll check back if they have passed then all good, if not I'll take a gander and submit a fix. Want a separate PR or happy to do it in here?

colinbull avatar Oct 14 '24 16:10 colinbull

If it comes down to it, I would prefer a separate fix, and then we'll just merge main back into this

JessicaTegner avatar Oct 14 '24 16:10 JessicaTegner

@colinbull it seems that the CI failing before was a fluke or something. It seems to be running now. If you are finished with the pr. We can merge it

JessicaTegner avatar Oct 27 '24 12:10 JessicaTegner

Ahhh, great. Sorry, I actually completely forgot I said I'd look at this.

As far as I'm concerned this is complete. So happy to merge.

colinbull avatar Oct 27 '24 13:10 colinbull