pypandoc Collect pandoc urls from github api

Aug 23 '24 06:08 nstrmx

Hey @nstrmx thanks for the PR.

Can you take a look at the failing checks. Do you think it's a PR issue, or something else?

Aug 23 '24 08:08 JessicaTegner

Fixed it (hopefully).

Aug 26 '24 07:08 nstrmx

Interestingly @nstrmx it seems that the single test failing, is actually because of a 403 rate limit. What would you say we could do about that? Asking because Idon't know that much about GHs api, when used in this way.

Sep 17 '24 05:09 JessicaTegner

If we add support for the GITHUB_TOKEN as an environment variable to be used in requests, will that solve this?

Oct 20 '24 15:10 nstrmx

yes, that would be acceptable. But I feel like that if that key isn't set, we should fall back to the old behaviour. Due to the nature of pypandoc, where it's used a lot in CI/CD workflows, I do think that if it's not set, we should fall back to old behaviour so stuff doesn't break

Oct 20 '24 16:10 JessicaTegner

Should work now.

Oct 26 '24 18:10 nstrmx

Great work. Lastly, since we now should have 2 download behaviors, we should probably make a test casefor each behavior

Oct 27 '24 13:10 JessicaTegner