SteamBot
SteamBot copied to clipboard
Jessecar96
Switch to use CallbackManager.Subscribe
The changes are not as hard to implement as it seems - and it looks a bit cleaned up too.
So, before:
And after:
If someone could teach me "how do I PR [without making myself look like a complete idiot]" then I'll issue a PR today or tomorrow that'll prevent SteamBot from dying when the changes take effect.
Here's my steam profile: Akashiya Moka - if one of you has what it takes to introduce a complete GitHub noob to PRs and stuff - 'pls' teach. :3
You don't need to store the callback instance in a variable as it won't be GC'd instantly as it internally registers itself with the callback manager.
I'm aware of that, the variable for it was "out of being used to registering everything" and I noticed this right after posting the screenshot.
Ok quick update for anyone who isn't following the SteamKit2 issue referenced. CallbackManager.Subscribe is coming for 1.6.4 of SteamKit2
SteamKit 1.6.5: 'CallbackMsgExtensions.Handle<T>(ICallbackMsg, Action<T>)" 'This method will be removed in a future version of SteamKit. Please migrate to CallbackManager.' ExampleBot SteamBot\Bot.cs 448
If you update SteamKit to 1.7.0 - there is errors that "Handle" is not exist.
Ya, latest steamkit version removed anything not needed but left CallbackManager.Subscribe as the only method to use.
This email has been sent from a virus-free computer protected by Avast. www.avast.com https://www.avast.com/sig-email <#DDB4FAA8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
On Thu, Feb 18, 2016 at 7:40 AM, doktokto [email protected] wrote:
SteamKit 1.6.5: 'CallbackMsgExtensions.Handle(ICallbackMsg, Action)" 'This method will be removed in a future version of SteamKit. Please migrate to CallbackManager.' ExampleBot SteamBot\Bot.cs 448
If you update SteamKit to 1.7.0 - there is errors that "Handle" is not exist.
— Reply to this email directly or view it on GitHub https://github.com/Jessecar96/SteamBot/issues/777#issuecomment-185703611 .
Can we please migrate ICallbackmsg to CallbackManager? It has been almost 1 and a half months o.0
I was able to do my migration to Subscribe myself, however I don't understand how I'm supposed to implement external Callbacks like "SteamNotifications.NotificationCallback" into SteamKit. Anyone managed that?
I'm currently working on a PR for this. My application needs to run on VPS but there is a bug in SteamKit causing error until 1.7. So it's kind of a must-have for me. I will also fully test it in a production environment before a PR is created.
@fjch1997 I haven't had any issues running it in a VPS. Try the mono-devel package instead of the default mono package.
@waylaidwanderer
Well, it seems that some virtual machines are fine. The related SteamKit issue is https://github.com/SteamRE/SteamKit/issues/200