TiddlyWiki5 icon indicating copy to clipboard operation
TiddlyWiki5 copied to clipboard

Summary of PRs that need TW changenotes

Open Jermolene opened this issue 1 month ago • 7 comments

The following PRs have been merged for v5.4.0 but do not yet have a changenote in the new format introduced by #9287 and refined in #9385.

I would like to ask the creators of these PRs to retrospectively submit a change note describing the changes in their PR. The new format is a bit more ambitious than previously, with changes and their impacts modelled as separate tiddlers. See the instructions for creating a changenote.

Please let me know if anything is unclear.

I appreciate it's asking a lot of people to undertake more work for this release, but I think it is very important to communicate the benefits of all the hard work that everyone has done – working through this list was a powerful reminder of how much talent and commitment we are lucky enough to enjoy.

  • [x] #9103 - @Arlen22
  • [x] #9135 - @Arlen22
  • [ ] #9262 - @bepuzzled
  • [ ] #9227 - @BurningTreeC
  • [ ] #9233 - @BurningTreeC
  • [ ] #9247 - @BurningTreeC
  • [x] #9295 - @cdruan
  • [x] #9341 - @cdruan
  • [x] #9358 - @cdruan
  • [ ] #9284 - @CrossEye
  • [ ] #9280 - @flibbles
  • [ ] #9297 - @flibbles
  • [ ] #5512 - @Jermolene
  • [ ] #8145 - @Jermolene
  • [ ] #9107 - @Jermolene
  • [x] #9118 - @Leilei332
  • [x] #9118 - @Leilei332
  • [x] #9119 - @Leilei332
  • [x] #9131 - @Leilei332
  • [x] #9154 - @Leilei332
  • [x] #9167 - @Leilei332
  • [x] #9218 - @Leilei332
  • [x] #9235 - @Leilei332
  • [x] #9243 - @Leilei332
  • [x] #9248 - @Leilei332
  • [x] #9253 - @Leilei332
  • [x] #9275 - @Leilei332
  • [x] #9288 - @Leilei332
  • [x] #9313 - @Leilei332
  • [x] #9316 - @Leilei332
  • [x] #9325 - @Leilei332
  • [x] #9328 - @Leilei332
  • [x] #9347 - @Leilei332
  • [x] #9350 - @Leilei332
  • [x] #8258 - @linonetwo
  • [x] #9078 - @linonetwo
  • [ ] #9349 - @oeyoews
  • [ ] #8176 - @pmario
  • [x] #8249 - @pmario
  • [x] #9015 - @pmario
  • [x] #9254 - @pmario
  • [x] #9281 - @pmario
  • [x] #9293 - @pmario
  • [x] #9317 - @pmario
  • [x] #9318 - @pmario
  • [ ] #9368 - @rishu-7549
  • [x] #9369 - @rishu-7549
  • [ ] #9084 - @s793016
  • [ ] #9206 - @saqimtiaz
  • [ ] #9207 - @saqimtiaz
  • [ ] #9259 - @saqimtiaz
  • [ ] #9260 - @saqimtiaz
  • [ ] #9024 - @well-noted
  • [x] #9305 - @yaisog
  • [x] #9337 - @yaisog

Jermolene avatar Nov 09 '25 16:11 Jermolene

I didn't know that. Should have been a github action bot to check this.

So I can also close #7542

linonetwo avatar Nov 09 '25 17:11 linonetwo

I didn't know that. Should have been a github action bot to check this.

Yes, it would be very helpful to check that the change note is present, and subject it to a basic sanity check.

Jermolene avatar Nov 09 '25 17:11 Jermolene

IMO we should use theme category instead of palette, which can include a wider range of updates including updating the palettes, icons and stylesheets.

Leilei332 avatar Nov 10 '25 09:11 Leilei332

IMO we should use theme category instead of palette, which can include a wider range of updates including updating the palettes, icons and stylesheets.

Thank you @Leilei332 I agree, theme would be much better. Would you be able to kindly make a PR?

Jermolene avatar Nov 11 '25 16:11 Jermolene

That will need to update

  1. editions\tw5.com\tiddlers\releasenotes\Release Notes and Changes.tid and editions\tw5.com\tiddlers\releasenotes\Release Notes and Changes Internals.tid
  2. editions\tw5.com\tiddlers\releasenotes\ReleasesInfo.multids
  3. https://github.com/TiddlyWiki/Cerebrus/blob/main/bin/ci-pr-validation/changenote.js

linonetwo avatar Nov 11 '25 17:11 linonetwo

@Jermolene see: Add pmario PR changenotes #9442

pmario avatar Dec 01 '25 12:12 pmario

I seem to be git-blind today, and have messed up two attempts at a PR, as well as one through the PR-maker. While I will try again later, I would not object at all if someone beats me to this:

change-category: widget
change-type: bugfix
description: Remove hard-coded CSS style properties when animation completes
github-contributors: CrossEye
github-links: https://github.com/TiddlyWiki/TiddlyWiki5/pull/9284
release: 5.4.0
tags: $:/tags/ChangeNote
title: $:/changenotes/5.4.0/9284

This removes certain hard-coded CSS style properties that were set when an animation completes, trying to 
restore the defaults; instead we remove the properties from the element. That fixes a class of small bugs in 
the storyviews: those properties were no longer available for animation through CSS transitions, and so 
certain animations were failing.

CrossEye avatar Dec 09 '25 03:12 CrossEye