TiddlyWiki5 icon indicating copy to clipboard operation
TiddlyWiki5 copied to clipboard

Add DiffTextWidget colors to some palettes

Open Leilei332 opened this issue 1 year ago • 7 comments

Add DiffTextWidget colors to Solarized, Solar Flare, Nord, GruvboxDark, DesertSand and Twlight palette to make them display properly.

Before:

图片

After:

图片

Leilei332 avatar Oct 04 '24 02:10 Leilei332

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Confirmed: Leilei332 has already signed the Contributor License Agreement (see contributing.md)

github-actions[bot] avatar Oct 04 '24 02:10 github-actions[bot]

If you have a look at the palette-manager edition: https://wikilabs.github.io/editions/palette-manager/ There are a lot of palettes, that have a WL at the end of the name.

All of them should have DiffText colours assigned. Some feedback would be welcome.

That's a reminder, that I should create a PR for all palettes. Since all of the core palettes have some missing elements.

pmario avatar Oct 04 '24 02:10 pmario

There are still a lot of palettes that doesn't have diff-* indexes in the palette manager edition, like the two palettes:

  • Solarized Light/Dark WL
  • Solar Flare WL
  • Spartan Day/Night WL

While those palettes have their own diff colors, which I think can be included in the PR:

  • Nord WL
  • DesertSand WL
  • GruvboxDark WL
  • Twlight WL

Leilei332 avatar Oct 04 '24 03:10 Leilei332

If they do not have the indexes in the palette, they use the default from vanilla. That is intended. But I will have a closer look. I have seen some problems with some dark palettes, where the text is invisible.

pmario avatar Oct 04 '24 05:10 pmario

Add DiffTextWidget colors to Solarized, Solar Flare, Nord, GruvboxDark, DesertSand and Twlight palette to make them display properly.

Thank you for using a consistent method for adding new color values! Everywhere you have use 6 chars hex code! Keep going on!

kookma avatar Oct 07 '24 03:10 kookma

I think only changing the foreground-colour is not enough. We have to take "colour blindness" into account.

Eg: this is "Nord dark WL" palette: Accessibility setting: Simulate: Protanopia (no red)

image

This is the same setting, that I use with my Palette-Manager edition, with the same Accessibility setting

image

The same screenshot for "normal vision"

image

pmario avatar Oct 07 '24 09:10 pmario

Deploy Preview for tiddlywiki-previews ready!

Name Link
Latest commit dfef1b0694fbe19d290a190a5e9a08f066d4f1ea
Latest deploy log https://app.netlify.com/sites/tiddlywiki-previews/deploys/67406e298b6ea20008a7a4d6
Deploy Preview https://deploy-preview-8661--tiddlywiki-previews.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Nov 22 '24 11:11 netlify[bot]

I've updated the palette to improve contrast:

图片

图片

Leilei332 avatar Nov 24 '24 10:11 Leilei332

Thanks @Leilei332

Jermolene avatar Dec 05 '24 12:12 Jermolene