TiddlyWiki5 icon indicating copy to clipboard operation
TiddlyWiki5 copied to clipboard

Published 20 hours ago • verified publisher icon Jermolene

Fix ribbon going over sticky tiddler title

Open Telumire opened this issue 11 months ago • 4 comments

isolation:isolate; is added to the style for the card in order to prevent the ribbon from going in front of the title bar while in position sticky.

before (without isolation:isolate;): image

after (with isolation:isolate;): image

I made a simplified demo of how isolation:isolate fix z-index issues: https://minimal-css.tiddlyhost.com/#snippet%2Ffixing%20z-index%2Fisolation

Telumire avatar Mar 21 '24 02:03 Telumire

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
tiddlywiki5 ✅ Ready (Inspect) Visit Preview Mar 21, 2024 2:19am

vercel[bot] avatar Mar 21 '24 02:03 vercel[bot]

~~Please check if there are existing PRs https://github.com/Jermolene/TiddlyWiki5/pull/8075~~

~~I did a complete rewrite, because the old one is completely bugged~~ IMO Hardcoded styles make everything worse

pmario avatar Mar 21 '24 09:03 pmario

@pmario I did check the other PR, but the issue comes from the card container, not the ribbon itself. I'll check your rewrite to see if it solve the issue, and I'll close this PR if it's the case (edit: it doesn't)

IMO Hardcoded styles make everything worse

I agree ! I was wondering if there was a reason why this was done this way

Telumire avatar Mar 21 '24 16:03 Telumire

Sorry my fault. I did see the fork-github-ribbon, but you posted the image of GettingStarted.

My linked PR has nothing to do with your PR . Sorry

pmario avatar Mar 21 '24 19:03 pmario