TiddlyWiki5 icon indicating copy to clipboard operation
TiddlyWiki5 copied to clipboard

action-createtiddler.js doesn't allow inheriting

Open thediveo opened this issue 7 years ago • 5 comments

As it seems, action-createtiddler.js doesn't allow reusing it, for insteance, to create a derived action-ensuretiddler.js that would create a tiddler only if it doesn't already exist. At the moment, inheriting seems to fail because the constructor always calls this.initialize unconditionally. For inheriting, it would be necessary to guard the call to this.initialize in the same way as in the base widget.js widget class.

thediveo avatar Apr 30 '18 16:04 thediveo

Hi @TheDiveO good point. If we're going to fix it we should do so for all of the core widgets.

Jermolene avatar May 02 '18 14:05 Jermolene

...oh well! ;)

thediveo avatar May 02 '18 17:05 thediveo

Hi @TheDiveO are you able to make. PR?

Jermolene avatar May 05 '18 07:05 Jermolene

Unfortunately not, as I've moved away from TW development.

thediveo avatar Dec 02 '25 18:12 thediveo

Unfortunately not, as I've moved away from TW development.

Hi @thediveo thanks for your contributions over the years, and we wish you well.

Jermolene avatar Dec 02 '25 19:12 Jermolene