Javascript.NodeJS icon indicating copy to clipboard operation
Javascript.NodeJS copied to clipboard

[Issue #179]: Adds System.Threading.Timer for aggregate change delay.

Open Zettersten opened this issue 1 year ago • 1 comments

Zettersten avatar Oct 11 '23 14:10 Zettersten

My bad, when I was looking through your changes I realized that I'd already written debouncing logic:

https://github.com/JeringTech/Javascript.NodeJS/blob/5999180f381cb41405f47eb31015be27dfb7facb/src/NodeJS/Utils/FileWatching/FileWatcherService.cs#L137-L177

We were debouncing, but with a fixed, small debounce time of 1ms.

Would you like to amend your PR to add an option for configuring that duration? Changes to OutOfProcessNodeJSService no longer necessary.

The option name/comments should indicate that we are debouncing, not aggregating changes over a set time period. Name should be something like "DebounceDuration".

JeremyTCD avatar Oct 12 '23 03:10 JeremyTCD