JeremyTCD

Results 37 comments of JeremyTCD

In beta 4 we were passing the configuration to the webpack script. Webpack was automatically minifying when mode was "release": https://github.com/JeringTech/Javascript.NodeJS/blob/41f70f4894379afc07e16edac370f4b8ea9f1a57/src/NodeJS/Jering.Javascript.NodeJS.csproj#L100-L101 https://github.com/JeringTech/Javascript.NodeJS/blob/41f70f4894379afc07e16edac370f4b8ea9f1a57/src/NodeJS/Javascript/webpack.config.js#L1-L27 In beta 5 we are no longer minifying:...

Odd that it is getting truncated. After changing minify to true, how are you running it locally? Could you try running the test suite? It passes on my windows 11...

The library escapes the script before starting the node process: https://github.com/JeringTech/Javascript.NodeJS/blob/5999180f381cb41405f47eb31015be27dfb7facb/src/NodeJS/NodeJSServiceImplementations/OutOfProcess/NodeJSProcessFactory.cs#L105-L158 This is where the process start info is created: https://github.com/JeringTech/Javascript.NodeJS/blob/5999180f381cb41405f47eb31015be27dfb7facb/src/NodeJS/NodeJSServiceImplementations/OutOfProcess/NodeJSProcessFactory.cs#L49-L59 Could you place breakpoints and take a closer look...

Yes it looks like line endings are the issue. Managed to repro with the script you pasted: ``` VM88 [eval1]:1 Uncaught SyntaxError: Unexpected end of input at ModuleLoader.evalInstance (VM83 loader:203:22)...

@CallumVass good catch, I've checked on my machine, the script you pasted has "\r\r\n" line endings. The original (pre-Vite minification) line: https://github.com/JeringTech/Javascript.NodeJS/blob/5999180f381cb41405f47eb31015be27dfb7facb/src/NodeJS/Javascript/Servers/OutOfProcess/Http/Http11Server.ts#L211 Not sure what is causing "\r\n"s to become...

> @CallumVass good catch, I've checked on my machine, the script you pasted has "\r\r\n" line endings. > > The original (pre-Vite minification) line: > > https://github.com/JeringTech/Javascript.NodeJS/blob/5999180f381cb41405f47eb31015be27dfb7facb/src/NodeJS/Javascript/Servers/OutOfProcess/Http/Http11Server.ts#L211 > > Not...

It works fine on my machine even though it's not on a single line. It's some other problem. If it's not the extra '\r's, I'm not sure what it is....

@CallumVass apologies on not having a solution. @aKzenT Yes I do. In the script the \0 is used to demarcate the end of log messages. Agree that it's suspicious his...

There is no way to to clear the require caches. > File watcher causes unexpected terminations for my case Do you have logs for this?

My bad, when I was looking through your changes I realized that I'd already written debouncing logic: https://github.com/JeringTech/Javascript.NodeJS/blob/5999180f381cb41405f47eb31015be27dfb7facb/src/NodeJS/Utils/FileWatching/FileWatcherService.cs#L137-L177 We were debouncing, but with a fixed, small debounce time of 1ms....