Results 621 comments of Jeremy Rand

@phelixbtc Just to be clear, the only HTTPS-specific code is the 1-line function at https://github.com/namecoin/nmcontrol/pull/58/files#diff-f0642a76a70a05557239a272a3cd10c6R19 , plus the 3 lines at https://github.com/namecoin/nmcontrol/pull/58/files#diff-f0642a76a70a05557239a272a3cd10c6R44 , plus (optionally, just for debug) the few...

@phelixbtc Also, are you intending for the obfuscated API to be added to NMControl? If so, can you make another ticket for that?

@phelixbtc I split off the HTTPS code. Anything else needed before we merge?

> Why do you not create a new session for every request? Isn't it the default anyway? Is there a benefit to keeping sessions? Using a single session allows the...

@phelixbtc What version of the requests module do you have? You're on Windows, right? Also try this: ``` pip install pyopenssl ndg-httpsclient pyasn1 ```

Hmm, I'll check on this and get back to you.

@phelixbtc As far as I can tell, get_servername should be being called on a Connection object, not a Context object. What version of PyOpenSSL are you on? How exactly did...

@phelixbtc thanks for posting the code you're using; I'll see if I can reproduce this on my end this weekend.

@phelixbtc I'm on PyOpenSSL 0.13.1, with requests 2.5.0, and I don't get that error when executing the file you posted. I do get this: ``` self: connection: x509: Traceback (most...

@phelixbtc I just tested in PyOpenSSL 0.14, and I can confirm that I get the same error you do. Now that I can reproduce it, I will work on a...