JointsWP icon indicating copy to clipboard operation
JointsWP copied to clipboard

JointsWP 6: Base Theme Style Discussion

Open JeremyEnglert opened this issue 6 years ago • 4 comments

As already discussed, JointsWP 6 will allow users to install whatever framework they chose or select to work without a framework. If a user decides to work without a framework, we need to decide what the "base theme" should include (in regards to styles).

Some things we need to think about:

  • Should we include some type of menu system? This is often something users struggle with, so having a starting point is nice. But at the same time, menu systems are becoming pretty unique across sites - so a "starter" menu might just get in the way.
  • Do we want to include any styles at all? Some themes such as Bones (fun fact: JointsWP started as a fork of Bones) include basic styles. While others, such as Underscores, include almost no styles at all. I learn towards having no styles.
  • Do we want to include a CSS reset as part of the base styles? If so, which one?

JeremyEnglert avatar Oct 15 '18 05:10 JeremyEnglert

Hi @JeremyEnglert!

Thanks for all your hard work with JointsWP - it’s helped me out on a couple occasions and I’m excited to contribute to the new release.

I share the same sentiment as you when it comes to a user deciding against using a framework; if a user decides to work without a framework the theme they receive should be completely stripped of all styling. This will allow developers to build out the front-end however they’d prefer. It also leaves the door open for developers (at agencies) to hook up their internal front-end stack/solution with the theme without having to worry about removing or editing files that are already in place.

This also applies to including a CSS reset as part of the base styles. If a user is going to fully customize the way the front-end is built out, why not give them the ability to decide on their reset as well? It's pretty easy to include a CSS reset, and some developers might have their own custom solutions that they'd like to use.

That’s all I have for now! :grin:

jspellman814 avatar Oct 17 '18 18:10 jspellman814

Thanks for the feedback! I really appreciate it!

I took the CSS reset out of the development branch. :)

JeremyEnglert avatar Oct 27 '18 05:10 JeremyEnglert

Here's some information about default styles for Gutenberg. Theme Support - https://wordpress.org/gutenberg/handbook/extensibility/theme-support/#default-block-styles Public Facing Stylesheet - https://plugins.trac.wordpress.org/browser/gutenberg/tags/4.2.0/build/block-library/theme.css

garretthyder avatar Nov 07 '18 22:11 garretthyder

Reveal Modals do not work on JointsWP 6. This is a fresh install with no active plugins.

andytc avatar Jan 31 '19 07:01 andytc