Jeroen Bouma
Jeroen Bouma
Sorry for hijacking your PR a little bit but I fixed: - The `maxdd` issue @deeleeramone referenced. - Fixed the same issue for `mret` - Some commands used sheet_name wrong...
Refractor `stocks/fa` by incorporating `stocks/dd` and making the menu less reliant on Yahoo Finance
I was playing around with fast_info and it doesn't seem to include all info so I sticked with `.info`. This PR isn't a 100% fix but mostly just moves things...
Refractor `stocks/fa` by incorporating `stocks/dd` and making the menu less reliant on Yahoo Finance
Updated but 100% tests won't work flawlessly. That's a task for next week.
Refractor `stocks/fa` by incorporating `stocks/dd` and making the menu less reliant on Yahoo Finance
> Does it make more sense to do things under `dd` instead of `fa` ? Since all the fa are technically dd but all the dd is not technically fa?...
Refractor `stocks/fa` by incorporating `stocks/dd` and making the menu less reliant on Yahoo Finance
@jmaslek I lack technological know-how to fix these merge conflicts. I gave it a shot but if I continue the chances are pretty high I'll just overwrite the wrong code....
Refractor `stocks/fa` by incorporating `stocks/dd` and making the menu less reliant on Yahoo Finance
@jmaslek I did it Mom!
Refractor `stocks/fa` by incorporating `stocks/dd` and making the menu less reliant on Yahoo Finance
Updated everything, should now be ready for review. I've looked into adding the features within the OpenBB SDK but I assume this happens automatically? I wanted to follow the guidelines...
Refractor `stocks/fa` by incorporating `stocks/dd` and making the menu less reliant on Yahoo Finance
@jmaslek That should do it!
Refractor `stocks/fa` by incorporating `stocks/dd` and making the menu less reliant on Yahoo Finance
Sure, I'd say I just make the command available again (and it send you to the fa menu) but not print it on the help menu anymore? ``` (🦋) /stocks/...