electron-ad-blocker icon indicating copy to clipboard operation
electron-ad-blocker copied to clipboard

Can't install module with electron 2.0.0 and node 8.9.3 on Travis CI

Open PaulRBerg opened this issue 7 years ago • 5 comments

I checked out the other issues and read your article.

I get the same #include "BloomFilter.h" error as in #3. I made sure that I have the right version of electron and node. Here's the log.

PaulRBerg avatar May 09 '18 09:05 PaulRBerg

Yeah, I have same error like you, although I installed with yarn too.

nhandt64 avatar Jun 16 '18 09:06 nhandt64

This package relies on another package called contains-ads which is also maintained by the beautiful @Jense5 as well. The contains-ads package relies on another package, ad-block by Brave Browser. The ad-block package version was depreciated which caused this build error. I've submitted a PR to contains-ads bumping the ad-block package version and fixing the build error. I cannot do a PR for this package until the PR from contains-ads is accepted as it relies on that package. So if you want, you guys can use this forked repo until it's fixed though once it does get fixed, you should definitely switch back.

ErraticFox avatar Dec 03 '18 21:12 ErraticFox

Hey guys, sorry for the late reply. I don't have much time right now but will try to fix this in the upcoming weekend.

Jense5 avatar Dec 04 '18 07:12 Jense5

Any updates on this?

I've tried using the forked repo but that doesn't seem to work for me either.

RedSparr0w avatar Mar 08 '19 21:03 RedSparr0w

@RedSparr0w maybe this other comment of mine would be useful to you as well: https://github.com/Jense5/electron-ad-blocker/issues/8#issuecomment-523567298

remusao avatar Sep 16 '19 08:09 remusao