thebeat icon indicating copy to clipboard operation
thebeat copied to clipboard

Rhythm: Notes not tied correctly

Open Jellevanderwerff opened this issue 1 year ago • 2 comments

rhythm = thebeat.music.Rhythm.from_integer_ratios([1, 2, 3, 2, 1, 2, 3, 2])
immagine

Jellevanderwerff avatar Jan 08 '24 13:01 Jellevanderwerff

In the first bar in the example above there's now 5 quarternotes and one dotted eighth note (makes zero sense).

Jellevanderwerff avatar Jan 08 '24 13:01 Jellevanderwerff

Working on it in fix_note_ties. Now, once done, we need to implement this in the Melody class as well!

Jellevanderwerff avatar Feb 01 '24 15:02 Jellevanderwerff

Another example: r = thebeat.music.Rhythm.from_integer_ratios([2, 3, 1, 2], beat_ms=600)

Jellevanderwerff avatar Dec 11 '24 11:12 Jellevanderwerff

New problem is in the construction of Rhythm objects, example:

r = thebeat.music.Rhythm.from_fractions([Fraction(3, 8), Fraction(5, 8)], time_signature=(2, 4), beat_ms=800)

Jellevanderwerff avatar Dec 12 '24 17:12 Jellevanderwerff

I closed the pull request because this has not yet been implemented in the Melody class!

Jellevanderwerff avatar Jan 29 '25 07:01 Jellevanderwerff