thebeat
thebeat copied to clipboard
Rhythm: Notes not tied correctly
rhythm = thebeat.music.Rhythm.from_integer_ratios([1, 2, 3, 2, 1, 2, 3, 2])
In the first bar in the example above there's now 5 quarternotes and one dotted eighth note (makes zero sense).
Working on it in fix_note_ties
. Now, once done, we need to implement this in the Melody
class as well!
Another example: r = thebeat.music.Rhythm.from_integer_ratios([2, 3, 1, 2], beat_ms=600)
New problem is in the construction of Rhythm objects, example:
r = thebeat.music.Rhythm.from_fractions([Fraction(3, 8), Fraction(5, 8)], time_signature=(2, 4), beat_ms=800)
I closed the pull request because this has not yet been implemented in the Melody
class!