Jelle van Assema comments

Results 24 comments of


                                            Jelle van Assema

In match_#.html, distro code is sometimes highlighted as an Exact match and not filtered out

That would essentially be a new method `exact-by-line`. But would be interesting to try out, given that for text/exact, lines are somewhat of a logical unit of information. Small gotchas...

Use pytest's plain asserts

The default `assert` is rather useless. It provides nothing to produce a `check50.Failure` from: ```Py try: assert 1 == 2 except AssertionError as e: print(e.args) # prints () ``` pytest...

I'm having some trouble replicating this issue for myself: ```sh /Projects/foo/ λ check50 liv-ac-uk/COMP108/2020-21/A1 Connecting..... Authenticating.... GitHub username: Jelleas GitHub password: Verifying............ Preparing..... Uploading............. Waiting for results.................................. Results for liv-ac-uk/comp108/2020-21/A1...

Uploading throws an error

@kzidane agree, we can do better here. Would just need to check for a prefix-branch, and warn and exit. Anyway, this would live in lib50, so let me just open...

Feature request: dynamically adding checks during execution?

I might have something to help you here. You're correct in that check50 creates a dependency DAG prior to executing checks. And because checks run in a separate process, it's...

Feature request: dynamically adding checks during execution?

> I am observing some really strange behaviour trying to reproduce your approach. Could you comment on this? check50 will create a directory (inside a temporary directory) for each check,...

Feature request: dynamically adding checks during execution?

> https://gist.github.com/pazz/f109183b56cf8919e1efd358f3b7cc9a I tried to replicate the error from this snippet, but I couldn't exactly. I did however run into another issue that might be the underlying cause of this....

Feature request: dynamically adding checks during execution?

> I am not sure how to debug my pset module during set up except by calling check50._api.log, Oh, looks like I'm blocking a PR that should make this easier....

Feature request: dynamically adding checks during execution?

This is semi-true, check50 runs checks in parallel by default through multi-processing. But because processes are relatively expensive to start, check50 uses a pool of them through `futures.ProcessPoolExecutor`. That means...

Feature request: dynamically adding checks during execution?

You're right, with the notebooks the time spent on creating the dynamic checks is rather negligible and as such I wasn't concerned with how many times it actually runs. I...