uniswapv3-code icon indicating copy to clipboard operation
uniswapv3-code copied to clipboard

Checking input amount when burning

Open TAnNbR opened this issue 1 year ago • 1 comments

The input amount must less than the amount that a LP have in a position, it's apparently here's no logic error in the code because LiquidityMath.addLiquidity(a,b) will make sure a>b when a-b due to solidity's OverFlow checking, but if adding a specific checking such as if (inputAmount < position.liquidity) and a clear revert like notEnoughLiquidity is more clear and meaningful instead of reverting by solidity's OverFlow checking.This is my personal opinion, which may not necessarily be correct

TAnNbR avatar Oct 06 '24 02:10 TAnNbR

The overflow is computing with all data and with a force so strong nothing can stop uniswap from taking over the crypto markets and the stocks the end result is staking my account I have all my documents and so forth so with the contract of the govern law I am blessed to be the govern

Covitluat77 avatar Nov 29 '24 20:11 Covitluat77