gtkterm icon indicating copy to clipboard operation
gtkterm copied to clipboard

Merge features from Sellerie

Open Jeija opened this issue 6 years ago • 2 comments

I recently found this project called Sellerie, which basically branched off from GTKTerm a couple of years ago. There was not a ton of development on GTKTerm during that time, but I collected a bunch of patches people wrote, added my own and pushblished it on GitHub. Since 2017 this repository is Debian's upstream for GTKTerm with @wvdakker as Debian's package maintainer.

From a purely technical point of view, Sellerie it appears to be a lot more modern than GTKTerm in multiple ways. E.g., I also took some of the code for the meson build system PR (#19) from there.

Here is a quick, incomplete comparison of GTKTerm and Sellerie: Sellerie

  • Uses Glade UI files for basically everything
  • Some bugfixes over original GTKTerm
  • Somewhat cleaner architecture, just a bit of strange French-lanuage code form original GTKTerm
  • Much more modern (e.g. no use of deprecated GtkStock, ...)
  • Hardly known at all

GTKTerm

  • Uses a lot of deprecated GTK / VTE functions
  • Basic architecture unchanged from original GTKTerm, some strange French-language code
  • Some bugfixes over original GTKTerm
  • More locales (German + Russian)
  • Device monitoring feature
  • Relatively well-known, a lot of users (probably more users than we might think, since GTKTerm is something that many people use without thinking very much about it)

My takeaway form this would be that we should maybe start looking into Selliere and think about porting some of the improvements over to GTKTerm / merging the two projects. I would personally suggest that the GTKTerm name should remain given that it is more well-known, but I'm also happy to have my opinion changed. From a licensing point of view this is certainly possible (both GPLv3), but before doing any of that I would like to know @phako's (Sellerie author) opinion on this matter and what he suggests. Of course we will have to credit @phako's work appropriately.

Any thoughts?

Jeija avatar Jul 20 '19 17:07 Jeija

Yes the forking history was a bit unfortunate, sorry.

I'm perfectly fine with you taking some code or even merging the two projects.

I also should probably also publish my UI refresher mocks somewhere.

phako avatar Jul 21 '19 07:07 phako

@Jeija, yes you are right we can use a uplift for gtkterm. I also agree the name gtkterm is preferable, just because renaming would take some unnecessary Debian (and derivatives) transition work.

Perhaps cherrypicking improvements would be easiest?

wvdakker avatar Jul 22 '19 08:07 wvdakker

2.0 will be a rewrite based on gtk4. Many of the improvements from Sellerie are included. (thanks to @phako)

wvdakker avatar Aug 17 '22 09:08 wvdakker