Jiaxin Shan

Results 742 comments of Jiaxin Shan

@Yard1 Should I wait for upstream to fix the document build issue?

@Yard1 Can you help check the failed test? I am not that sure whether it's related to this change. The test suite pass earlier. I didn't see this test is...

Looks like it still has that error. I am running a 4-gpu node and run `test/lora/test_long_context.py` against the master branch and see what happens.

### master branch test pass Master branch ``` root@37bd47dfb2b2:/workspace/vllm# export VLLM_WORKER_MULTIPROC_METHOD=spawn root@37bd47dfb2b2:/workspace/vllm# pytest -v -s -x tests/lora/test_long_context.py The cache for model files in Transformers v4.22.0 has been updated. Migrating your...

![image](https://github.com/user-attachments/assets/2dab4768-ae46-4a48-b700-f401af8a88d9) lora issue fixed but there's PP issue. I made an minor comment change to trigger the tests

@Yard1 Please have another look. The previous failure has been fixed and all tests pass now

@Yard1 Do you have further comments or suggestion on this PR? I have some other WIP PR need this change. If this can be merged, that definitely simplify the rebase...

@ZXTFINAL it's supposed to be model agnostic. Do you mind cutting an issue with more details? Please cc me and I can help debug it.

@Yard1 Please help check this issue for a short term doc fix

@Yard1 Yeah, I think the idea here is to give user an idea they should append the full path instead of giving them 100% correct path. This is from some...