Jeffrey Hamer
Jeffrey Hamer
> Thanks @Jeffrieh. I really like the stateless refactor, formatting style, and new build system, excellent work. I also understand your point to remove the tests, we can build a...
Hi David! Some good points, I created it to have a clear seperation between network and client options. I think these two should stay seperate for now, and i think...
hmm right, it indeed looks a bit redundant to pass the network to both the session and the client, perhaps we can extend our `createClient` function to either accept a...
as for the types, i think it's fine for now to tightly couple it to wharkit's version of chains/networks, initially i tried to keep it a bit more generic but...
Good catch !! I think there was something wrong with the enum/object indexing for the actions, i fixed that now, could you try it again ?
these errors seem to be related to undeployed contracts on mainnet
Hi David! I agree, i think including and exporting the wharfkit session functionality inside of the SDK is a better approach then what we have now, we just have to...
i re-exported the Session class from @wharfkit/session so that one can be extracted from the @effectai/sdk now. I think re-exporting the wharfkit/wallet-plugin-privatekey doesn't make much sense because its not used...
Hi guys, any updates on this ?