spleeter-web icon indicating copy to clipboard operation
spleeter-web copied to clipboard

reform frontend out of Docker stuff + other Docker

Open jtagcat opened this issue 2 years ago • 4 comments

  • other Docker things

to get all images on cli: docker build -t t:latest-celery-fast . --target=celery-fast docker build -t t:latest-celery-slow . --target=celery-slow docker build -t t:latest . --target=api docker build -t t:latest-gpu -f gpu.Dockerfile . (compose: see docker-compose files)

Closes #122

GPU not tested, others tested.

jtagcat avatar Feb 13 '22 19:02 jtagcat

Thanks for reorganizing!

I'd like to keep the existing behaviour with docker-compose.dev.yml where a frontend service is running npm run dev (webpack in watch mode) and has a shared volume that maps to the local host machine's frontend/src. It simplifies debugging/development by rebuilding the frontend automatically after modifying the source on the host machine. It doesn't seem to work anymore with these changes.

JeffreyCA avatar Feb 20 '22 02:02 JeffreyCA

Would using a separate Dockerfile for debug (stop at step before adding frontend + frontend separate)/prod be fine?

jtagcat avatar Feb 22 '22 11:02 jtagcat

anygay, I'll try to split up the commit if I can

edit: can do: include frontend in api, but it can be overwritten by mounting to the same location (making using frontend image optional)

jtagcat avatar Feb 22 '22 11:02 jtagcat

Yeah that's fine

JeffreyCA avatar Feb 22 '22 17:02 JeffreyCA