Ashley Jeffs

Results 229 comments of Ashley Jeffs

Closing for now but if anything comes up I'd like to reopen and reuse this issue.

Thanks @theRealWardo, totally agree with your main points there. I think the fundamental problem has been that different client libraries like to obfuscate connectivity and cancellation in their own ways...

Whoops, forgot to close this, thanks for the update @skolem-dan!

Hey @danthegoodman1, I finally got around to looking at this, I've made a branch with a rework of this input so that it works similar to the input SQL components,...

Just as an update, I've had another look at this and I'm still stumped. I've implemented the ability to store and obtain a cursor from any cache resource: https://github.com/benthosdev/benthos/tree/crdb-changefeed, however...

Done, merged via https://github.com/benthosdev/benthos/commit/ab0a2bc34486e97b5c913774f02d897c4a4cc60e

Thanks @kabukky, I finally got around to working on this, I've done a pretty hefty rewrite of some bits, especially the docs/functions, but the core bits are mostly the same....

> Thanks so much @Jeffail I'm not sure about the VM re-use via the pool. Goja runtime re-use is tricky. See here for example: [dop251/goja#291](https://github.com/dop251/goja/issues/291) Yeah I had a play...

@saholman yeah I'd be happy to take a PR, ideally something interacting with the AWS client libraries directly rather than via another dependency, but happy to take a look at...

Fixed with https://github.com/benthosdev/benthos/commit/2225bf849ba2637c3dba91708036e968b6bea99d