res-loglikelihood-regression icon indicating copy to clipboard operation
res-loglikelihood-regression copied to clipboard

Published 20 hours ago • verified publisher icon Jeff-sjtu

bar_mu computation is different from the paper in Eq (5)

Open superaha opened this issue 1 year ago • 2 comments

Hi there,

It seems the bar_mu computation is different. Should be multiplying a "-1". (below Eqn (5), bar_mu = (gt - mu_pred) / sigma.

As shown here:

https://github.com/Jeff-sjtu/res-loglikelihood-regression/blob/203dc3195ee5a11ed6f47c066ffdb83247511359/rlepose/models/regression_nf.py#L134

This does not affect the computation of log_Q, which basically using the abs of this term. How about the flow model? Not sure if this leads to any difference in the learning of the flow model RealNVP, or did i miss something here?

Thanks.

superaha avatar Nov 18 '22 23:11 superaha