HybrIK icon indicating copy to clipboard operation
HybrIK copied to clipboard

Why is the version of spicy specified

Open wanzysky opened this issue 2 years ago • 3 comments

In https://github.com/Jeff-sjtu/HybrIK/blob/c821072e87d20807e662424cc11fe5377c39220e/setup.py#L125 , the version of spicy is specified as 1.1.0 that is too old for new Python such as 3.8 or newer. May I know the cause?

wanzysky avatar Jul 26 '21 04:07 wanzysky

Hi, we only test the 1.1.0 version. But I think a higher version of scipy may also work.

Jeff-sjtu avatar Jul 27 '21 09:07 Jeff-sjtu

As announced in https://docs.scipy.org/doc/scipy-1.2.1/reference/generated/scipy.misc.imread.html , the function imread is removed in scipy 1.2, and imageio.imread is recommended.

The usage in this code is https://github.com/Jeff-sjtu/HybrIK/blob/c821072e87d20807e662424cc11fe5377c39220e/hybrik/datasets/hp3d.py#L157 (and image loading in other datasets).

wanzysky avatar Jul 27 '21 12:07 wanzysky

Thanks @wanzysky , we will update the code.

Jeff-sjtu avatar Jul 28 '21 07:07 Jeff-sjtu