HybrIK icon indicating copy to clipboard operation
HybrIK copied to clipboard

Published 20 hours ago • verified publisher icon Jeff-sjtu

Potential unintentional overwrite of children list

Open rubenvillegas opened this issue 3 years ago • 1 comments

Looks like the "-3" used to rotate joints that have 3 children is overwritten here: https://github.com/Jeff-sjtu/HybrIK/blob/e10afb149e10cf721b619b12eb81f02b7ad3c4e0/hybrik/models/layers/smpl/SMPL.py#L160

Is this on purpose?

rubenvillegas avatar Jun 10 '21 18:06 rubenvillegas

Hi, this actually works for both cases. When setting it to neck, the rotation of spine3 will be composed by the swing rotation and the twist rotation of neck.

Jeff-sjtu avatar Jun 15 '21 14:06 Jeff-sjtu