react-select icon indicating copy to clipboard operation
react-select copied to clipboard

Fix types compatibility with React 19

Open Methuselah96 opened this issue 1 year ago • 2 comments

Fixes #5911.

React 19 removes the JSX type from the global scope, so it now needs to be imported from React.

This causes some immediate issues for the users of react-select who are trying to use it with @types/react@19, since the Select types relies on the JSX.LibraryManagedAttributes type.

Note that this is technically a breaking change because it requires TypeScript users to have a version of @types/react after https://github.com/DefinitelyTyped/DefinitelyTyped/pull/64464 shipped.

Methuselah96 avatar Jun 04 '24 02:06 Methuselah96

🦋 Changeset detected

Latest commit: ed73fc2e638cf15bfd8d9cdc36d56c266a5f9f91

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
react-select Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jun 04 '24 02:06 changeset-bot[bot]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codesandbox-ci[bot] avatar Jun 04 '24 02:06 codesandbox-ci[bot]

NextJS 15 is now released and it includes React 19 RC

j2ghz avatar Nov 06 '24 22:11 j2ghz

@j2ghz Do you want to create a PR with these changes? If so, I can approve, merge, and, release it. (I can't approve my own PR.)

Methuselah96 avatar Nov 06 '24 22:11 Methuselah96

Superseded by #5974

Methuselah96 avatar Nov 09 '24 14:11 Methuselah96