react-select icon indicating copy to clipboard operation
react-select copied to clipboard

Fix event handling with react-beautiful-dnd

Open itsdouges opened this issue 2 years ago • 3 comments

This pull request removes logic to bail out from an event if someone else listening to the event (usually in a capture phase) has called preventDefault(). This fixes interop between react-select and react-beautiful-dnd.

To ensure things don't regress, and to ensure to not contradict what was solved in https://github.com/JedWatson/react-select/pull/5134 I've added four e2e tests covering the various flows in both:

  • an emulated react-beautiful-dnd environment, and
  • direct react-calendar interop

All tests pass, the same behaviour remains, hopefully we're good to go.

TODO

  • [ ] fix tests
  • [ ] assess the solution and seek alternatives if needed

Closes https://github.com/JedWatson/react-select/issues/5833

itsdouges avatar Jan 09 '24 05:01 itsdouges

🦋 Changeset detected

Latest commit: 16b4be76f8952cfbb4a4f6e6df715c28b751a325

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
react-select Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jan 09 '24 05:01 changeset-bot[bot]

cc @rkulinski @flexdinesh

itsdouges avatar Jan 09 '24 05:01 itsdouges

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 16b4be76f8952cfbb4a4f6e6df715c28b751a325:

Sandbox Source
react-codesandboxer-example Configuration

codesandbox-ci[bot] avatar Jan 09 '24 05:01 codesandbox-ci[bot]