react-select icon indicating copy to clipboard operation
react-select copied to clipboard

Input on css is not valid.

Open riimako opened this issue 3 years ago • 2 comments

Hey! I am using the react-select in my project, and the W3 validator gives me this Error: CSS: label: Property label doesn't exist.

From line 50, column 62128; to line 50, column 62549
-value=""><input type="text" class="reactSelect__input" style="label:input;color:inherit;background:0;opacity:…x="0" value="" aria-autocomplete="list" aria-expanded="false" aria-haspopup="true" role="combobox"/></div>

Referenced code is here: https://github.com/JedWatson/react-select/blob/564a14306f3086a83b959ca89eaa909eeb4db77c/packages/react-select/src/components/Input.tsx#L81 https://github.com/JedWatson/react-select/blob/b0411ff46bc1ecf45d9bca4fb58fbce1e57f847c/packages/react-select/src/components/Input.js#L32

This is not valid css, and should not be there, to see more about css properties click.

This should be easy fix, and maybe you want to use aria-label?

Thanks!

riimako avatar Sep 22 '22 13:09 riimako

I have the same issue. Any fix for this?

levipadre avatar Oct 16 '23 11:10 levipadre

The referenced code is still present at last version at time of writing

https://github.com/JedWatson/react-select/blob/a8b8f4342cc113e921bb238de2dd69a2d345b5f8/packages/react-select/src/components/Input.tsx#L88

although I was not able to make it rendered live.

@ebonow Since it is introduced from your commit at https://github.com/JedWatson/react-select/commit/2ad934545#diff-07753302222b58b652fb23698902955708f7f700fdeecf15980423588766fef4R77, is there a particular reason why you introduced this label: 'input' line ?

htech9 avatar Sep 24 '24 08:09 htech9