JedWatson
feature/always-focus-first-menu-option
Adds a new property called "alwaysFocusFirstMenuOption" that makes it possible to keep focus on the first item when the list of options is changed. An example can be seen below:
-
Without prop:
-
With prop:
⚠️ No Changeset found
Latest commit: c960bdf11ffbaeecef6d72f5fd76fcb1c2eb3ede
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
![changeset-bot[bot] avatar](https://avatars.githubusercontent.com/in/28616?v=4 "Published by a pub.dev verified publisher"){kind=small}
This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Latest deployment of this branch, based on commit c960bdf11ffbaeecef6d72f5fd76fcb1c2eb3ede:
| Sandbox | Source |
|---|---|
| react-codesandboxer-example | Configuration |
![codesandbox-ci[bot] avatar](https://avatars.githubusercontent.com/in/38409?v=4 "Published by a pub.dev verified publisher"){kind=small}
Is this one similar to the request of https://github.com/JedWatson/react-select/pull/4080?
Is this one going to be merged into master soon?
This PR (open for 1 year) and #4080 (open for 2 years) fix the same thing, that currently cannot be worked around. It would be extremely cool to finally merge this one. The solution is simple and elegant but nobody is merging anything.
Pinging @andrevitalb because I saw recent commit/merge activity from you. Do you think you can help? Thanks! :)
This PR (open for 1 year) and #4080 (open for 2 years) fix the same thing, that currently cannot be worked around. It would be extremely cool to finally merge this one. The solution is simple and elegant but nobody is merging anything.
Pinging @andrevitalb because I saw recent commit/merge activity from you. Do you think you can help? Thanks! :)
@stnwk I'm just able to add reviews, don't have write access, We still need @JedWatson for that.
Oh, thanks for your time and work anyways! Hopefully we can move forward here
@andrevitalb can you review again? any chance of the functionality being merged? thanks for your time
@andrevitalb can you review again? any chance of the functionality being merged? thanks for your time
@andersonmfjr I don't have any write permissions for the repo. We'd have to wait for @JedWatson's approval
@andersonmfjr thanks for the pull request, but I wonder, maybe the more sustainable approach here (for the library and maintainers) is to only support 1 behaviour, and then encourage consumers to control the component themselves if they need something else.
Related
- https://github.com/JedWatson/react-select/pull/4080
@andersonmfjr thanks for the pull request, but I wonder, maybe the more sustainable approach here (for the library and maintainers) is to only support 1 behaviour, and then encourage consumers to control the component themselves if they need something else.
Related
Do you think it is possible to achieve this same behavior with the components control?
In the related PR it only shows that workarounds were done. And apparently they didn't work out so well.
@JedWatson can we please merge this, if possible? Lot of people are requesting for this feature and we don't want to do unnecessarily complex workarounds
