Jean Mertz

Results 119 comments of Jean Mertz

I just tried this in my terminal, and gocode is definitely returning values as expected: ```shell echo -e "package main\n\nfunc main() {\n strconv.At\n}\n" | gocode -f json autocomplete . 40...

When enabling debug logging in the client, I see the following response returned by the server: ``` {'isIncomplete': False, 'items': []} ```

After digging some more, I guess the reason is that the code that I found regarding `gocode` is vendored code, and it looks like `go-langserver` doesn't use the file-based gocode...

I validated that this diff works as expected: ```diff diff --git a/langserver/internal/gocode/export.go b/langserver/internal/gocode/export.go index ac533ff..00a0b70 100644 --- a/langserver/internal/gocode/export.go +++ b/langserver/internal/gocode/export.go @@ -9,6 +9,7 @@ var bctx go_build_context func InitDaemon(bc *build.Context)...

I just noticed that this breaks if you trigger autocomplete on a package that doesn't exist. Using this file: ```golang package main func main() { } ``` If I write...

Seems to originate from here: https://github.com/sourcegraph/go-langserver/blob/7f84cdc942f706cf3e36bdbd5c5bf6e1f8cb044b/langserver/internal/gocode/decl.go#L35-L36

In the end, I copy/pasted the latest master source of `gocode` into `go-langserver` (and removed some unrelated changes/code), it now works as expected. Full diff here: https://gist.github.com/JeanMertz/aeb524db3b6eabfa46d9298ac228f1a5 I suspect this...

Thinking some more about this (after being head down on this issue for the past two hours) I just realize that it could be because the javascript doesn't get evaluated...

Has there been any progress on this in the recent months, or anything planned for the foreseeable future? It would definitely be great to see the operator support NATS Streaming....

I ran into this same "problem". In my case, it was with `EachKey`. This is the diff that reduced the allocs from 2 to 1, since, indeed, this allocation is...